linux-kernel - AW: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <85496C0905BB194FBDA1572571DBE95D0949FC36@FLBVEXCH01.versatel.local>
Date:	Thu, 7 Aug 2008 13:01:38 +0200
From:	"Andreas.Eversberg" <Andreas.Eversberg@...satel.de>
To:	<benh@...nel.crashing.org>, "Karsten Keil" <kkeil@...e.de>
Cc:	"Sean MacLennan" <smaclennan@...atech.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	<isdn4linux@...tserv.isdn4linux.de>, <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

please note that some cards require MEMIO. disabling it means disabling card types. if there are other future access modes and bridges, they can be implemented and then be selected by the vendor and device ids. read, write and fifo read, write are functions,  assigned to pointers at runtime. also wrapping (slightly) different hardware access is possible in the future. i think we should leave it like it is.

also note:  reading or writing fifos via PIO is optimized and almost as fast as MEMIO, since io-address byte never changes during fifo access. (auto-incemented after access).

-----Ursprüngliche Nachricht-----
Von: Benjamin Herrenschmidt [mailto:benh@...nel.crashing.org] 
Gesendet: Mittwoch, 6. August 2008 02:34
An: Karsten Keil
Cc: Sean MacLennan; Linus Torvalds; Andreas.Eversberg; isdn4linux@...tserv.isdn4linux.de; linux-kernel@...r.kernel.org
Betreff: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

On Wed, 2008-08-06 at 02:18 +0200, Karsten Keil wrote:
> 
> For the xhfc this may be a differnt choice, to select the access method on
> compile time, because the chip is mainly used for embedded systems, so it
> do not need to have a generic driver, the kerne is usually configured
> exactly for the hardware. On the other side, if you look into the xhfc
> chip and documentation, it is not so different from the HFC 4/8S, so maybe
> it would be possible to integrate it in hfcmulti as well.
> 
> And maybe here is a third way, to have a tristate CONFIG MEMIO,PIO,BOTH,
> which could be imlemented in the none indirect call version without
> overhead. I think I like this idea.

That's probably the best way. On powerpc, we have done a lot of work
to make it possible to have kernels support multiple platforms
even in the embedded space. You don't have to do it, but we found it
important to allow for it.

It forces to keep the code cleaner, but also makes it possible for
somebody release a range of products based on different designs to
support/release single binary images for the entire product range
(at least provided it's the same CPU core "family", we don't currently
support single binaries mixing for example 44x and 8xx processor
support). What to actually do at runtime being decided based on the
content of a "device-tree" passed to the kernel by the firmware or the
boot wrapper.

Thus, I find it a good idea to allow the option even for embedded
drivers to be built with runtime detection of access method.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/