linux-kernel - Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080807134634.GA1450@pingi.kke.suse.de>
Date:	Thu, 7 Aug 2008 15:46:34 +0200
From:	Karsten Keil <kkeil@...e.de>
To:	"Andreas.Eversberg" <Andreas.Eversberg@...satel.de>
Cc:	benh@...nel.crashing.org, Sean MacLennan <smaclennan@...atech.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	isdn4linux@...tserv.isdn4linux.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

On Thu, Aug 07, 2008 at 01:01:38PM +0200, Andreas.Eversberg wrote:
> please note that some cards require MEMIO. disabling it means disabling 
> card types. if there are other future access modes and bridges,
> they can be implemented and then be selected by the vendor and device ids.
> read, write and fifo read, write are functions,
> assigned to pointers at runtime. also wrapping (slightly) different hardware
> access is possible in the future. i think we should leave it like it is.
(Please break long lines)

No, disabling modes is a valid optimation for self compiled kernel versions,
which are for exact one hardware, yes for normal hardware you would not able
to meassure the difference, but for embedded systems it makes sense.
Of course this is nothing a distribution will use.

I think we should remove the indirect calls, they are not needed here, even if
here are other future  access methods. Modern CPUs are lot better in optimation
conditional branches so this cost much less as a indirect call. Note on a 
static call the cpu can prefetch the instructions for the call target as soon
it decodes the call itself - with a indirect call, it cannot start prefetching
until the address is calculated and loaded).

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/