linux-kernel - Re: [PATCH 08/42] introduce nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440808091421n50fd4b25i73e1bd00d7a8a67e@mail.gmail.com>
Date:	Sat, 9 Aug 2008 14:21:45 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, "Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Mike Travis" <travis@....com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/42] introduce nr_irqs

On Sat, Aug 9, 2008 at 9:02 AM, Eric W. Biederman <ebiederm@...ssion.com> wrote:
> "Yinghai Lu" <yhlu.kernel@...il.com> writes:
>
>>> Also, what's the point, if it's just a renaming?
>>
>> that is the start point.
>> nr_irqs is variable, and will be probed later. and use that number to
>> init dyn_alloc.
>
> YH.
>
> In my conception the code in kernel/irq.c that today does:
>
> struct irq_desc *desc;
> if (irq >= NR_IRQS)
>   return -EINVAL;
> desc = irq_desc + irq;
>
> Should become:
>
> struct irq_desc *desc;
> desc = irq_desc(irq);
> if (!desc)
>   return -EINVAL;
>

OK.

also want to introduce dummy
struct irq_desc
{
   unsigned int irq;
};

in linux/interrupt.h if GENERIC_HARDIRQS is not defined.
so could have same interface
irq_desc()
and
for_each_irq_desc(irq, desc)

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/