linux-kernel - Re: [PATCH 08/42] introduce nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <489CFA0A.5030609@zytor.com>
Date:	Fri, 08 Aug 2008 18:59:38 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	Mike Travis <travis@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/42] introduce nr_irqs

Yinghai Lu wrote:
> On Fri, Aug 8, 2008 at 6:00 PM, Eric W. Biederman <ebiederm@...ssion.com> wrote:
>> Yinghai Lu <yhlu.kernel@...il.com> writes:
>>
>>> and at this point it is equal NR_IRQS
>> This patch is ok, but this approach is fundamentally broken.
>> Only 19 architectures use GENERIC_HARDIRQS
>>
>> The only required interface is interrupt.h not irq.h
>>
>> So you may not replace NR_IRQS with nr_irqs in anything other
>> then genirq code and some architecture code.
>>
>> Doing so will break the build on several architectures.
> 
> some platforms will not use include/linux/irq.h and kernel/irq/handle.c ?
> 

Also, what's the point, if it's just a renaming?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/