linux-kernel - Re: [PATCH] cgroup.c: remove goto statement from cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <je8wv3dhil.fsf@sykes.suse.de>
Date:	Mon, 11 Aug 2008 11:32:02 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	"Rakib Mullick" <rakib.mullick@...il.com>
Cc:	"Paul Menage" <menage@...gle.com>, "Paul Jackson" <pj@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup.c: remove goto statement from cgroup_init.

"Rakib Mullick" <rakib.mullick@...il.com> writes:

> Hello everyone, following patch removes the use of goto statement.
> Actually, we don't need it. Beacuse, if "err < 0", then it will never
> be TRUE.

What is "it"?

> --- linux-2.6.27-rc2.orig/kernel/cgroup.c	2008-08-11 15:16:49.000000000 +0600
> +++ linux-2.6.27-rc2/kernel/cgroup.c	2008-08-11 15:16:26.000000000 +0600
> @@ -2562,11 +2562,10 @@ int __init cgroup_init(void)
>
>  	err = register_filesystem(&cgroup_fs_type);
>  	if (err < 0)
> -		goto out;
> +		return err;
>
>  	proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations);
>
> -out:
>  	if (err)
>  		bdi_destroy(&cgroup_backing_dev_info);

Doesn't this create a resource leak?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@...e.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/