linux-kernel - Re: [PATCH] cgroup.c: remove goto statement from cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Aug 2008 02:35:21 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Rakib Mullick" <rakib.mullick@...il.com>
Cc:	"Paul Jackson" <pj@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup.c: remove goto statement from cgroup_init.

On Mon, Aug 11, 2008 at 2:25 AM, Rakib Mullick <rakib.mullick@...il.com> wrote:
> Hello everyone, following patch removes the use of goto statement.
> Actually, we don't need it. Beacuse, if "err < 0", then it will never
> be TRUE.

"err" will be regarded by the compiler as true if it's anything other
than 0. So this patch introduces breakage.

Paul

> So, we can skip the goto statement and can just return.
> Thanks.
>
> Signed-off-by: Rakib Mullick (rakib.mullick@...il.com)
>
> --- linux-2.6.27-rc2.orig/kernel/cgroup.c       2008-08-11 15:16:49.000000000 +0600
> +++ linux-2.6.27-rc2/kernel/cgroup.c    2008-08-11 15:16:26.000000000 +0600
> @@ -2562,11 +2562,10 @@ int __init cgroup_init(void)
>
>        err = register_filesystem(&cgroup_fs_type);
>        if (err < 0)
> -               goto out;
> +               return err;
>
>        proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations);
>
> -out:
>        if (err)
>                bdi_destroy(&cgroup_backing_dev_info);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/