linux-kernel - Re: [PATCH 1/1] iwlwifi: fix printk newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1218502555.25524.22.camel@californication>
Date:	Tue, 12 Aug 2008 02:55:55 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linville@...driver.com, linux-wireless@...r.kernel.org,
	ipw3945-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Zhu Yi <yi.zhu@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>
Subject: Re: [PATCH 1/1] iwlwifi: fix printk newlines

Hi Jiri,

> Add newlines at printk outputs to not break dmesg.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Zhu Yi <yi.zhu@...el.com>
> Cc: Reinette Chatre <reinette.chatre@...el.com>
> Cc: John W. Linville <linville@...driver.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl-4965.c     |    2 +-
>  drivers/net/wireless/iwlwifi/iwl-eeprom.c   |    6 +++---
>  drivers/net/wireless/iwlwifi/iwl-sta.c      |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl-tx.c       |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl3945-base.c |    6 +++---
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 22bb269..4a0cc78 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> @@ -967,7 +967,7 @@ static int iwl4965_interpolate_chan(struct iwl_priv *priv, u32 channel,
>  
>  	s = iwl4965_get_sub_band(priv, channel);
>  	if (s >= EEPROM_TX_POWER_BANDS) {
> -		IWL_ERROR("Tx Power can not find channel %d ", channel);
> +		IWL_ERROR("Tx Power can not find channel %d\n", channel);
>  		return -1;
>  	}

can we not just fix IWL_ERROR to always append the newline?

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/