lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea8d860a0808130016w646307few3cc6385caf9b1ec7@mail.gmail.com>
Date:	Wed, 13 Aug 2008 08:16:02 +0100
From:	"Marcin Obara" <marcin_obara@...rs.sourceforge.net>
To:	"Greg KH" <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Intel Management Engine Interface

2008/8/13 Greg KH <greg@...ah.com>:
> On Mon, Aug 11, 2008 at 09:23:01PM +0200, Marcin Obara wrote:
>> +/* IOCTL commands */
>> +#define IOCTL_HECI_GET_VERSION \
>> +    _IOWR('H' , 0x0, struct heci_message_data)
>
> This can easily be a sysfs file, why not do that instead?
>
sysfs file would require additional file handle used by every userspace client.
GET_VERSION is called frequently, and sysfs file would create extra overhead.
With ioctl - only one file handle is used, and userspace client logic
is simpler.
Normal flow looks like:

open
ioctl(GET_VERSION)
ioctl(CONNECT)
... - do some operations - depends on version
close

or:

open
ioctl(CONNECT)
.. - do some operations
close


-- 
Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ