linux-kernel - Re: invalidate caches before going into suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808131011050.3462@nehalem.linux-foundation.org>
Date:	Wed, 13 Aug 2008 10:17:26 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mark Langsdorf <mark.langsdorf@....com>
cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: invalidate caches before going into suspend

On Wed, 13 Aug 2008, Mark Langsdorf wrote:
> 
> I don't think it's necessary.  I can submit a delta patch later if you
> think it's really necessary.

Why not at least move it to after the local_irq_disable()?

That local_irq_disable() will do tons of writes if you have 
lockdep enabled, it calls trace_hardirqs_off() etc. Maybe they don't end 
up ever mattering, but wouldn't it make much more sense to just move the 
wbinvd down to just before the

	while (1)
		halt();

which is also likely to make sure that the compiler won't do anything at 
all because everything is dead at that point with no function calls etc 
happening.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/