linux-kernel - Re: can block drivers get non-fs requests?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080814143935.7033631e@mjolnir.drzeus.cx>
Date:	Thu, 14 Aug 2008 14:39:35 +0200
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Alex Dubov <oakad@...oo.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: can block drivers get non-fs requests?

On Thu, 14 Aug 2008 13:42:09 +0200
Jens Axboe <jens.axboe@...cle.com> wrote:

> 
> You should check in the driver whether the request type is supported. So
> if you can only handle fs requests, you should do a check for
> !blk_fs_request() after elv_next_request() and call
> end_(de)queued_request() appropriately.
> 

So killing off the request with -EOPNOTSUPP is preferred over having a
prepare function and stopping it there?

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)