linux-kernel - Re: can block drivers get non-fs requests?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080814140612.GC20055@kernel.dk>
Date:	Thu, 14 Aug 2008 16:06:12 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Pierre Ossman <drzeus-list@...eus.cx>
Cc:	Alex Dubov <oakad@...oo.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: can block drivers get non-fs requests?

On Thu, Aug 14 2008, Pierre Ossman wrote:
> On Thu, 14 Aug 2008 13:42:09 +0200
> Jens Axboe <jens.axboe@...cle.com> wrote:
> 
> > 
> > You should check in the driver whether the request type is supported. So
> > if you can only handle fs requests, you should do a check for
> > !blk_fs_request() after elv_next_request() and call
> > end_(de)queued_request() appropriately.
> > 
> 
> So killing off the request with -EOPNOTSUPP is preferred over having a
> prepare function and stopping it there?

Nope, that doesn't matter. If you already have a prep function, using
BLKPREP_KILL is the easiest solution.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/