lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Aug 2008 20:41:00 +0100 (BST) From: "Maciej W. Rozycki" <macro@...ux-mips.org> To: Cyrill Gorcunov <gorcunov@...il.com> cc: mingo@...e.hu, tglx@...utronix.de, hpa@...or.com, yhlu.kernel@...il.com, linux-kernel@...r.kernel.org Subject: Re: [patch 7/8] x86: apic - unify sync_Arb_IDs On Thu, 1 Jan 1970, Cyrill Gorcunov wrote: Hmm, are you living in the past? > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com> > --- > > diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c > index 1d5f830..ec0f18f 100644 > --- a/arch/x86/kernel/apic_32.c > +++ b/arch/x86/kernel/apic_32.c > @@ -919,8 +919,7 @@ void __init sync_Arb_IDs(void) > apic_wait_icr_idle(); > > apic_printk(APIC_DEBUG, "Synchronizing Arb IDs.\n"); > - apic_write(APIC_ICR, > - APIC_DEST_ALLINC | APIC_INT_LEVELTRIG | APIC_DM_INIT); > + apic_write(APIC_ICR, APIC_DEST_ALLINC | APIC_INT_LEVELTRIG | APIC_DM_INIT); > } > > /* [etc...] Well, I think this one is backwards... There are exceptions, but the general rule is to with within the width of the terminal. Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists