linux-kernel - Re: [patch 8/8] x86: apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0808151614460.11843@cliff.in.clinika.pl>
Date:	Fri, 15 Aug 2008 16:31:57 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>, tglx@...utronix.de, hpa@...or.com,
	yhlu.kernel@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [patch 8/8] x86: apic - unify init_bsp_APIC

On Fri, 15 Aug 2008, Cyrill Gorcunov wrote:

> Since lapic_is_integrated is just eliminated on 64bit I thought
> it's better to have smooth code flow as much as possible. By 'smooth'
> I mean to not use #ifdef until there is no chance to escape from.

 Of course!

> And Maciej - you're so right - if someone will take a look on the
> apic_64.c code now he will be quite wondered what lapic_is_integrated
> is doing in 64bit code.

 I just questioned the purpose of reformatting the comment.  I see no
problem with lapic_is_integrated() appearing in 64-bit code -- if someone
cannot figure out why it would appear there, they better practised some
thinking at home before coming back.  We have plenty of places with such
constructs that expand to literals for some configurations all over our
tree anyway.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/