linux-kernel - Re: [patch 1/3] kmsg: Kernel message catalog macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3ece790808171031ra5edf9dvfdaa3417bf5a7e37@mail.gmail.com>
Date:	Sun, 17 Aug 2008 10:31:35 -0700
From:	"Tim Hockin" <thockin@...kin.org>
To:	schwidefsky@...ibm.com
Cc:	"Rusty Russell" <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	lf_kernel_messages@...ts.linux-foundation.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Michael Holzheu" <holzheu@...ibm.com>,
	"Gerrit Huizenga" <gh@...ibm.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Randy Dunlap" <randy.dunlap@...cle.com>,
	"Jan Kara" <jack@...e.cz>, "Pavel Machek" <pavel@....cz>,
	"Sam Ravnborg" <sam@...nborg.org>, "Joe Perches" <joe@...ches.com>,
	"Jochen Voß" <jochen.voss@...glemail.com>,
	"Kunai Takashi" <kunai@...ux-foundation.jp>,
	"Tim Bird" <tim.bird@...sony.com>
Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros.

On Sun, Aug 17, 2008 at 10:28 AM, Martin Schwidefsky
<schwidefsky@...ibm.com> wrote:
> On Sat, 2008-08-16 at 13:40 -0700, Tim Hockin wrote:
>> >> > > Can you hash the format string to generate the id?  6 hex digits should
>> >> > > be enough, and your tool can check for clashes.  As it's bad form to have
>> >> > > identical strings for different semantics anyway, this seems to make
>> >> > > sense.
>>
>> > Ok, so  a specialized version of printk will do the work to calculate
>> > the hash. Only, what will we do if there ever is a conflict? The message
>> > tag has to be unique. The shorter the hash is, the more likely a
>> > collision gets. Don't know if 6 hash digits is enough to just ignore the
>> > problem.
>>
>> And if you ever need to change the text that is in the format string?
>> The hash changes.  That seems exactly counter to your goal...
>
> The only problem here is trivial change like typos. Then the hash
> changes although the message is semantically still the same. If the
> message really changes, its id should change as well.

That's what I meant.  Never underestimate the urge to fix the
printk(), because "hey, it's JUST A PRINTK".  That's one of my
motivations - to make it no longer just a printk.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/