linux-kernel - Re: [patch 2/2] reduce tlb/cache flush times of agpgart memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080818080344.GK30694@elte.hu>
Date:	Mon, 18 Aug 2008 10:03:44 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Li, Shaohua" <shaohua.li@...el.com>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"airlied@...ux.ie" <airlied@...ux.ie>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [patch 2/2] reduce tlb/cache flush times of agpgart memory
	allocation


* Li, Shaohua <shaohua.li@...el.com> wrote:

> > it would be great if you had time to update his patch and this to 
> > it...
>
> I'll do it soon.

great! Please do it as a delta patch against tip/master:

   http://people.redhat.com/mingo/tip.git/README

as your first two patches are being tested already:

 466ae83: reduce tlb/cache flush times of agpgart memory allocation
 1ac2f7d: introduce two APIs for page attribute

[ but it can all only go upstream once the observations from Arjan have
  been addressed. ]

> > and the logic probably should be "if there's more than X pags in the 
> > the array, just use wbinvd". Although wbinvd is very painful if you 
> > have 12Mb of cache and you wipe it for all cores in the system ;-(
>
> This might not be that bad, changing attribute isn't frequently used.

dont some X/DRM drivers do it for a wide range of GX ops?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/