linux-kernel - Re: [PATCH] virtio_balloon: fix towards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808182115210.3324@nehalem.linux-foundation.org>
Date:	Mon, 18 Aug 2008 21:17:12 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Anthony Liguori <aliguori@...ibm.com>
cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Avi Kivity <avi@...ranet.com>,
	virtualization@...ts.linux-foundation.org,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH] virtio_balloon: fix towards_target when deflating
 balloon



On Mon, 18 Aug 2008, Anthony Liguori wrote:
> 
> Nothing.  It works just fine.  However, I implemented it more verbosely
> because this is the second time we've "fixed" this problem.  See
> 
> commit bdc1681cdf1ab6a65fa935a2b3f8fc63b20c54ea
> Author: Rusty Russell <rusty@...tcorp.com.au>
> Date:   Mon Mar 17 22:58:15 2008 -0500
> 
>    virtio: handle > 2 billion page balloon targets

Well, we could perhaps add a sparse warning that makes noise when a 
unsigned subtraction is cast to a wider signed field. I dunno if it would 
catch anything interesting, or just cause a ton of irritating noise.

> So I thought I'd rely a little less on the subtleties of promotion and make
> things a bit more clear.  However, I don't feel that strongly about it so here
> you go.

Ugly and inefficient is not acceptable, even for these kinds of reasons. 
So yes, the simpler version is much better.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/