linux-kernel - Re: [PATCH] virtio_balloon: fix towards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808191122.54845.rusty@rustcorp.com.au>
Date:	Tue, 19 Aug 2008 11:22:54 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Anthony Liguori <aliguori@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, Avi Kivity <avi@...ranet.com>,
	virtualization@...ts.linux-foundation.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH] virtio_balloon: fix towards_target when deflating balloon

On Tuesday 19 August 2008 08:15:31 Anthony Liguori wrote:
> -	return v - vb->num_pages;
> +	if (v < vb->num_pages)
> +		return -(s64)(vb->num_pages - v);
> +	else
> +		return v - vb->num_pages;

With all due respect, WTF?

Did you mean:

	return (s64)v - vb->num_pages;

I'm really amazed this bug got this far though...
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/