linux-kernel - Re: [PATCH 05/10] ldisc: new dcd_change() method for line disciplines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080820111117.0113da05@lxorguk.ukuu.org.uk>
Date:	Wed, 20 Aug 2008 11:11:17 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 05/10] ldisc: new dcd_change() method for line
 disciplines.

O> #ifdef CONFIG_PPS_IRQ_EVENTS
>                 ts = pps_irq_ts[port->irq];
> #else

That bit won't work very shortly - IRQ numbers are going sparse not a
single simple NR_IRQ array.

> This completely hides the (dirty) trick to the PPS clients and allow
> using struct tty_struct as first parameter.

Can we get the basics right first - drop the IRQ_EVENTS and HARDPPS
hackery out of the patchset and the core code then looks quite clean.
After that is sorted/merged we can come back to working out the best way
to improve the IRQ and HARDPPS hacks.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/