linux-kernel - Re: [PATCH 09/10] PPS: low level IRQ timestamps recording.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080820103115.GA3912@elte.hu>
Date:	Wed, 20 Aug 2008 12:31:15 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Rodolfo Giometti <giometti@...ux.it>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 09/10] PPS: low level IRQ timestamps recording.


* Rodolfo Giometti <giometti@...ux.it> wrote:

> Add low level IRQ timestamps recording for x86 (32 and 64 bits)
> platforms and enable UART clients in order to use it.
> 
> This improves PPS precision. :)
> 
> Signed-off-by: Rodolfo Giometti <giometti@...ux.it>
> ---
>  arch/x86/kernel/irq_32.c        |   18 ++++++++++++++++++
>  arch/x86/kernel/irq_64.c        |   22 ++++++++++++++++++++--
>  drivers/pps/Kconfig             |   12 ++++++++++++
>  drivers/pps/clients/pps-ldisc.c |   18 ++++++++++++++++++
>  include/linux/pps.h             |    1 +
>  5 files changed, 69 insertions(+), 2 deletions(-)

hm, NACK on this line of approach. If then this instrumentation should 
be done at the genirq level (kernel/irq/*.c). Also, the #ifdefs are ugly 
- please hide them in include files.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/