linux-kernel - Re: VolanoMark regression with 2.6.27-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1219242796.8651.54.camel@twins>
Date:	Wed, 20 Aug 2008 16:33:16 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	adobriyan@...il.com
Cc:	Ingo Molnar <mingo@...e.hu>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	Aneesh Kumar KV <aneesh.kumar@...ux.vnet.ibm.com>,
	Balbir Singh <balbir@...ibm.com>,
	Chris Friesen <cfriesen@...tel.com>
Subject: Re: VolanoMark regression with 2.6.27-rc1

On Wed, 2008-08-20 at 18:32 +0400, adobriyan@...il.com wrote:
> On Wed, Aug 20, 2008 at 03:32:17PM +0200, Peter Zijlstra wrote:
> > On Wed, 2008-08-20 at 12:51 +0200, Ingo Molnar wrote:
> > > * Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> > > 
> > > > And I must admit to having overlooked the effect on wake_affine..
> > > > 
> > > > Chris, could you see the effect of this on smp group fairness?
> > 
> > Just realized my brainfart..
> > 
> > ---
> > Subject: sched: load-balance bias fixes
> > From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Date: Wed Aug 20 15:28:51 CEST 2008
> > 
> > Yanmin spotted a regression with my patch that introduces LB_BIAS:
> > 
> >   commit 93b75217df39e6d75889cc6f8050343286aff4a5
> >   Author: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> >   Date:   Fri Jun 27 13:41:33 2008 +0200
> > 
> > And I just spotted the brainfart - I should have replaced min/max with avg
> > instead of removing it completely.
> 
> > --- linux-2.6.orig/include/linux/kernel.h
> > +++ linux-2.6/include/linux/kernel.h
> > @@ -367,6 +367,12 @@ static inline char *pack_hex_byte(char *
> >  	(void) (&_max1 == &_max2);		\
> >  	_max1 > _max2 ? _max1 : _max2; })
> >  
> > +#define avg(x, y) ({				\
> > +	typeof(x) _avg1 = ((x)+1)/2;		\
> > +	typeof(x) _avg2 = ((y)+1)/2;		\
> 
> ITYM, typeof(y)

you thought right, I did mean that :-)

> > +	(void) (&_avg1 == &_avg2);		\
> > +	_avg1 + _avg2; })
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/