linux-kernel - [patch for 2.6.27? 1/1] nfs: BUG_ON in nfs_follow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1219303124.6621.8.camel@iris.sw.ru>
Date:	Thu, 21 Aug 2008 11:18:44 +0400
From:	"Denis V. Lunev" <den@...nvz.org>
To:	Trond.Myklebust@...app.com
Cc:	bfields@...ldses.org, akpm@...ux-foundation.org, den@...nvz.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: [patch for 2.6.27? 1/1] nfs: BUG_ON in nfs_follow_mountpoint
	(Trond's comment fixed)

From: "Denis V. Lunev" <den@...nvz.org>

Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside
nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup.

See https://bugzilla.redhat.com/show_bug.cgi?id=458622

So the situation should be handled on NFS client gracefully.

Signed-off-by: Denis V. Lunev <den@...nvz.org>
Cc: Trond Myklebust <Trond.Myklebust@...app.com>
Cc: J. Bruce Fields <bfields@...ldses.org>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 fs/nfs/namespace.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -puN fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint fs/nfs/namespace.c
--- a/fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint
+++ a/fs/nfs/namespace.c
@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(stru
 
 	dprintk("--> nfs_follow_mountpoint()\n");
 
-	BUG_ON(IS_ROOT(dentry));
+	err = -EIO;
+	if (IS_ROOT(dentry))
+		goto out_err;
+
 	dprintk("%s: enter\n", __func__);
 	dput(nd->path.dentry);
 	nd->path.dentry = dget(dentry);
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/