linux-kernel - Re: Help with compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jemyj29xwl.fsf@sykes.suse.de>
Date:	Sun, 24 Aug 2008 18:32:26 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Benny Halevy <bhalevy@...asas.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>
Subject: Re: Help with compiler warning

Larry Finger <Larry.Finger@...inger.net> writes:

> Benny Halevy wrote:
>> On Aug. 24, 2008, 18:29 +0300, Benny Halevy <bhalevy@...asas.com> wrote:
>>> On Aug. 22, 2008, 4:36 +0300, Larry Finger <Larry.Finger@...inger.net> wrote:
>>>> In drivers/pcmcia/cardbus.c, the following statement
>>>>
>>>>          memcpy_fromio(ptr, s->cb_cis_virt + addr, len);
>>>>
>>>> generates the warning
>>>>
>>>>    CC [M]  drivers/pcmcia/cardbus.o
>>>> include/asm/io_32.h: In function ‘memcpy_fromio’:
>>>> include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’
>>>> discards qualifiers from pointer target type
>>>>
>>>> s->cb_cis_virt is "void __iomem" and addr is uint.
>>>>
>>>> What cast does argument 2 need to silence the warning?

The cast needs to be in memcpy_fromio, but there is already one, so why
do you get a warning in the first place?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@...e.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/