linux-kernel - oops due to smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48B18F2E.8090108@qumranet.com>
Date:	Sun, 24 Aug 2008 19:41:18 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Ingo Molnar <mingo@...e.hu>, Nick Piggin <npiggin@...e.de>
CC:	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: oops due to smp_call_function_single changes

My 2s x 2c Intel server (Xeon 5150) won't boot anymore.  I bisected this to

commit cc7a486cac78f6fc1a24e8cd63036bae8d2ab431
Author: Nick Piggin <nickpiggin@...oo.com.au>
Date:   Mon Aug 11 13:49:30 2008 +1000

    generic-ipi: fix stack and rcu interaction bug in 
smp_call_function_mask()
   
    * Venki Pallipadi <venkatesh.pallipadi@...el.com> wrote:
   
    > Found a OOPS on a big SMP box during an overnight reboot test with
    > upstream git.
    >
    > Suresh and I looked at the oops and looks like the root cause is in
    > generic_smp_call_function_interrupt() and smp_call_function_mask() 
with
    > wait parameter.
    >
[...]
    Nice debugging work.
   
    I'd suggest something like the attached (boot tested) patch as the 
simple
    fix for now.
   
    I expect the benefits from the less synchronized, 
multiple-in-flight-data
    global queue will still outweigh the costs of dynamic allocations. But
    if worst comes to worst then we just go back to a globally synchronous
    one-at-a-time implementation, but that would be pretty sad!
   
    Signed-off-by: Ingo Molnar <mingo@...e.hu>


Reverting this commit (and cc7a486cac78f6fc1a24e8cd63036bae8d2ab431, 
which is an add-on fix) allows my guest to boot.

My .config can be found in 
http://userweb.kernel.org/~avi/scf-oops/config.  I have an oops 
somewhere inside a mobile phone but have yet to find a way to dig it 
out.  Netconsole doesn't work for me built-in for some reason, and this 
is during boot (I think during the loading of the ahci modules).

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/