linux-kernel - Re: [BUG] cpufreq: constant cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080825175547.GA26131@codemonkey.org.uk>
Date:	Mon, 25 Aug 2008 13:55:47 -0400
From:	Dave Jones <davej@...emonkey.org.uk>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	cpufreq@...r.kernel.org, Alok Kataria <akataria@...are.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [BUG] cpufreq: constant cpu_khz

On Mon, Aug 25, 2008 at 02:39:26PM +0200, Ingo Molnar wrote:
 > 
 > * Peter Zijlstra <peterz@...radead.org> wrote:
 > 
 > > > I noticed that my sched_clock() was slow on a number of machine, so 
 > > > I started looking at cpufreq.
 > > 
 > > The below seems to fix the problem for me, but I don't have enough 
 > > clue to know if its the correct fix, please advise.
 > 
 > > -	set_cyc2ns_scale(tsc_khz_ref, freq->cpu);
 > > +	set_cyc2ns_scale(tsc_khz, freq->cpu);
 > 
 > hm, that too is due to the tsc.c unification - Alok Cc:-ed. Applied your 
 > fix to x86/urgent.

ACKed-by: Dave Jones <davej@...hat.com>

Good catch Peter.  I'm puzzled how that bug was latent on 64bit
for so long with no-one realising though.

	Dave

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/