linux-kernel - Re: [PATCH] exit signals: use of uninitialized field notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080827080136.GA4453@elte.hu>
Date:	Wed, 27 Aug 2008 10:01:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steve VanDeBogart <vandebo-lkml@...dBox.Net>
Cc:	linux-kernel@...r.kernel.org, Roland McGrath <roland@...hat.com>,
	Oleg Nesterov <oleg@...sign.ru>
Subject: Re: [PATCH] exit signals: use of uninitialized field notify_count


* Steve VanDeBogart <vandebo-lkml@...dBox.Net> wrote:

> task->signal->notify_count is only initialized if
> task->signal->group_exit_task is not NULL.  Reorder a conditional so
> that uninitialised memory is not used.  Found by Valgrind.
>
> Signed-off-by: Steve VanDeBogart <vandebo-lkml@...dbox.net>

Applied the commit below to tip/core/urgent, thanks. Roland/Oleg, do you 
concur with the fix?

nice find btw. - are you running Valgrind on UML?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/