linux-kernel - Re: [PATCH] USB: add USB test and measurement class driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Aug 2008 10:56:36 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Greg KH <greg@...ah.com>
Cc:	linux-usb@...r.kernel.org, Stefan Kopp <stefan_kopp@...lent.com>,
	Marcel Janssen <korgull@...e.nl>,
	Felipe Balbi <me@...ipebalbi.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: add USB test and measurement class driver

Am Mittwoch 27 August 2008 02:05:01 schrieb Greg KH:

> I've now added this to my tree, and any review comments are greatly
> welcome.

Unfortunately the issues are not trivial.

1. USBTMC_SIZE_IOBUFFER
use 2048. 4096 means a multipage allocation

2. usbtmc_open race with disconnect
already mailed about

3. read/write and, if you convert to unlocked_ioctl, need protection
against reentry

4. read, write & ioctl need protection against using a rebound interface
you add a mutex, that you need for (3) anyway to the descriptor and protected
by this mutex you set the interface and device pointers to null in disconnect
and check them in the affected methods

5.get_capabilities
kmalloced buffer is never freed

6. disconnect fails to remove sysfs attributes

7. probe will report success even if usb_register_dev fails

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/