[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080827152848.GA19710@kroah.com>
Date: Wed, 27 Aug 2008 08:28:48 -0700
From: Greg KH <greg@...ah.com>
To: Oliver Neukum <oliver@...kum.org>
Cc: linux-usb@...r.kernel.org, Stefan Kopp <stefan_kopp@...lent.com>,
Marcel Janssen <korgull@...e.nl>,
Felipe Balbi <me@...ipebalbi.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: add USB test and measurement class driver
On Wed, Aug 27, 2008 at 10:56:36AM +0200, Oliver Neukum wrote:
> Am Mittwoch 27 August 2008 02:05:01 schrieb Greg KH:
>
> > I've now added this to my tree, and any review comments are greatly
> > welcome.
>
> Unfortunately the issues are not trivial.
Nah, they are all easily fixable :)
> 1. USBTMC_SIZE_IOBUFFER
> use 2048. 4096 means a multipage allocation
So? What difference does this really matter at normal USB speeds?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists