lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 28 Aug 2008 07:31:23 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	harvey.harrison@...il.com, mingo@...e.hu,
	paulmck@...ux.vnet.ibm.com
Subject: Re: + rcu-fix-sparse-shadowed-variable-warning.patch added to -mm
	tree

> --- a/kernel/rcuclassic.c~rcu-fix-sparse-shadowed-variable-warning
> +++ a/kernel/rcuclassic.c
> @@ -561,15 +561,15 @@ static void __rcu_process_callbacks(stru
>  		local_irq_restore(flags);
>  
>  		if (rcu_batch_after(rdp->batch, rcp->pending)) {
> -			unsigned long flags;
> +			unsigned long flags2;
>  
>  			/* and start it/schedule start if it's a new batch */
> -			spin_lock_irqsave(&rcp->lock, flags);
> +			spin_lock_irqsave(&rcp->lock, flags2);
>  			if (rcu_batch_after(rdp->batch, rcp->pending)) {
>  				rcp->pending = rdp->batch;
>  				rcu_start_batch(rcp);
>  			}
> -			spin_unlock_irqrestore(&rcp->lock, flags);
> +			spin_unlock_irqrestore(&rcp->lock, flags2);
>  		}
>  	}

Bzzzrt... just remove second variable.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists