linux-kernel - Re: + rcu-fix-sparse-shadowed-variable-warning.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1219895491.6069.4.camel@brick>
Date:	Wed, 27 Aug 2008 20:51:31 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	paulmck@...ux.vnet.ibm.com
Subject: Re: + rcu-fix-sparse-shadowed-variable-warning.patch added to -mm
	tree

On Thu, 2008-08-28 at 07:31 +0400, Alexey Dobriyan wrote:
> > --- a/kernel/rcuclassic.c~rcu-fix-sparse-shadowed-variable-warning
> > +++ a/kernel/rcuclassic.c
> > @@ -561,15 +561,15 @@ static void __rcu_process_callbacks(stru
> >  		local_irq_restore(flags);
> >  
> >  		if (rcu_batch_after(rdp->batch, rcp->pending)) {
> > -			unsigned long flags;
> > +			unsigned long flags2;
> >  
> >  			/* and start it/schedule start if it's a new batch */
> > -			spin_lock_irqsave(&rcp->lock, flags);
> > +			spin_lock_irqsave(&rcp->lock, flags2);
> >  			if (rcu_batch_after(rdp->batch, rcp->pending)) {
> >  				rcp->pending = rdp->batch;
> >  				rcu_start_batch(rcp);
> >  			}
> > -			spin_unlock_irqrestore(&rcp->lock, flags);
> > +			spin_unlock_irqrestore(&rcp->lock, flags2);
> >  		}
> >  	}
> 
> Bzzzrt... just remove second variable.
> 

>>From my original e-mail:

It would be safe in this case to just remove the second declaration of flags
and reuse it as it is outside the local_irq_save/restore pair.  I did it
this
way in case there are future changes that might mix up the use of flags.

Feel free to just remove the second flags declaration if you'd rather do
it
that way.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/