linux-kernel - Re: [PATCH] ide: Build fix for CONFIG_IDE_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48B92CB6.2090702@ru.mvista.com>
Date:	Sat, 30 Aug 2008 15:19:18 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Elias Oltmanns <eo@...ensachen.de>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ide: Build fix for CONFIG_IDE_PROC_FS=n

Hello.

Elias Oltmanns wrote:
> Recent changes have broken compilation when CONFIG_IDE_PROC_FS is not set.
>
> Signed-off-by: Elias Oltmanns <eo@...ensachen.de>
>   
[...]
> diff --git a/drivers/ide/ide-disk.h b/drivers/ide/ide-disk.h
> index f937772..5254cae 100644
> --- a/drivers/ide/ide-disk.h
> +++ b/drivers/ide/ide-disk.h
> @@ -23,8 +23,10 @@ ide_decl_devset(acoustic);
>  /* ide-disk_ioctl.c */
>  int ide_disk_ioctl(struct inode *, struct file *, unsigned int, unsigned long);
>  
> +#ifdef CONFIG_IDE_PROC_FS
>  /* ide-disk_proc.c */
>  extern ide_proc_entry_t ide_disk_proc[];
>  extern const struct ide_proc_devset ide_disk_settings[];
> +#endif /* CONFIG_IDE_PROC_FS */
>  
>  #endif /* __IDE_DISK_H */
> diff --git a/drivers/ide/ide-floppy.h b/drivers/ide/ide-floppy.h
> index 2ad373e..86ee37e 100644
> --- a/drivers/ide/ide-floppy.h
> +++ b/drivers/ide/ide-floppy.h
> @@ -53,8 +53,10 @@ sector_t ide_floppy_capacity(ide_drive_t *);
>  /* ide-floppy_ioctl.c */
>  int ide_floppy_ioctl(struct inode *, struct file *, unsigned, unsigned long);
>  
> +#ifdef CONFIG_IDE_PROC_FS
>  /* ide-floppy_proc.c */
>  extern ide_proc_entry_t ide_floppy_proc[];
>  extern const struct ide_proc_devset ide_floppy_settings[];
> +#endif /* CONFIG_IDE_PROC_FS */
>   

   Is surrounding 'extern' declarations by #ifdef's really of any value?
   They shouldn't be used if CONFIG_IDE_PROC_FS=n, so no object file 
records should be generated.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/