linux-kernel - Re: [PATCH] proc: don't confuse /bin/ps by zombie delay_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080901100631.GA133@tv-sign.ru>
Date:	Mon, 1 Sep 2008 14:06:31 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Roland McGrath <roland@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Albert Cahalan <acahalan@...il.com>,
	Alexey Dobriyan <adobriyan@...nvz.org>,
	Michael Kerrisk <mtk.manpages@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: don't confuse /bin/ps by zombie delay_group_leader's

On 08/31, Roland McGrath wrote:
>

(re-ordered)

> We've known it behaved this way for a very long time, and I've always
> considered it procps's problem to display such situations in ways that
> users find most useful.  It can already quickly tell that situation by a
> "Threads:" line with >1 when "State:" says "Z".

Agreed. It is much better to change /bin/ps and do not touch the kernel.
Albert, what do you think?

Please ignore this patch.

> I don't think it's right to change /proc/pid/task/tid/status this way.
> The real status is true and correct for the individual task, no matter what.
> If you want to change /proc/pid/status, then you ought to split it into
> proc_tgid_status and proc_tid_status variants to differ this way.

Perhaps yes, but

> If you do change it, it
> might be nicer to display it as a (compatible) special case:
>
> State:	S (delayed-leader)

Or "Z (delayed-leader)" if we fix ps. In this case both /proc/pid/status
and /proc/pid/task/tid/status can report the same state.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/