[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080901010753.8FA4D154243@magilla.localdomain>
Date: Sun, 31 Aug 2008 18:07:53 -0700 (PDT)
From: Roland McGrath <roland@...hat.com>
To: Oleg Nesterov <oleg@...sign.ru>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Albert Cahalan <acahalan@...il.com>,
Alexey Dobriyan <adobriyan@...nvz.org>,
Michael Kerrisk <mtk.manpages@...glemail.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: don't confuse /bin/ps by zombie delay_group_leader's
I don't think it's right to change /proc/pid/task/tid/status this way.
The real status is true and correct for the individual task, no matter what.
If you want to change /proc/pid/status, then you ought to split it into
proc_tgid_status and proc_tid_status variants to differ this way.
I don't really have an opinion either way about this for /proc/pid/status.
We've known it behaved this way for a very long time, and I've always
considered it procps's problem to display such situations in ways that
users find most useful. It can already quickly tell that situation by a
"Threads:" line with >1 when "State:" says "Z". If you do change it, it
might be nicer to display it as a (compatible) special case:
State: S (delayed-leader)
Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists