[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48BD4D42.2090504@sgi.com>
Date: Tue, 02 Sep 2008 16:27:14 +0200
From: Jes Sorensen <jes@....com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
CC: David Miller <davem@...emloft.net>, travis@....com, mingo@...e.hu,
Alan.Brunelle@...com, tglx@...utronix.de, rjw@...k.pl,
linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org,
akpm@...ux-foundation.org, arjan@...ux.intel.com,
rusty@...tcorp.com.au
Subject: Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
Linus Torvalds wrote:
>
> On Fri, 29 Aug 2008, Jes Sorensen wrote:
>> I have only tested this on ia64, but it boots, so it's obviously
>> perfect<tm> :-)
>
> Well, it probably boots because it doesn't really seem to _change_ much of
> anything.
>
> Things like this:
>
> -static inline void arch_send_call_function_ipi(cpumask_t mask)
> +static inline void arch_send_call_function_ipi(cpumask_t *mask)
> {
> - smp_ops.send_call_func_ipi(mask);
> + smp_ops.send_call_func_ipi(*mask);
> }
>
> will still do that stack allocation at the time of the call. You'd have to
> pass the thing all the way down as a pointer..
Linus,
Ok, so here's a version which tries to do the right thing on x86 as
well. Build tested on x86_64, but don't have an easy way to test it
right now. It's booting on ia64.
Cheers,
Jes
View attachment "0040-smp-call-cpumask.patch" of type "text/plain" (26201 bytes)
Powered by blists - more mailing lists