linux-kernel - Re: HID: make compat functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48C05F2B.1030608@gmail.com>
Date:	Fri, 05 Sep 2008 00:20:27 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Jiri Kosina <jkosina@...e.cz>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: HID: make compat functions static

Hi,

does the hid-dummy module runtime-link after the change?

ANSI C standard says:
* In the set of translation units and libraries that constitutes an entire
program, each declaration of a particular identiﬁer with external linkage
denotes the same object or function. Within one translation unit, each
declaration of an identiﬁer with _internal linkage_ denotes the same object or
function. Each declaration of an identiﬁer with no linkage denotes a unique entity.
* If the declaration of a ﬁle scope identiﬁer for an object or a function
contains the storage-class speciﬁer _static_, the identiﬁer has _internal linkage_.
* For an identiﬁer declared with the storage-class speciﬁer _extern_ in a scope
in which a _prior declaration_ of that identiﬁer is visible, if the prior
declaration speciﬁes _internal_ or external linkage, the linkage of the
identiﬁer at the later declaration _is the same as the linkage speciﬁed at the
prior declaration_. If no prior declaration is visible, or if the prior
declaration speciﬁes no linkage, then the identiﬁer has external linkage.

(Note that EXPORT_SYMBOL adds extern.)

I can't find any extension of gnu C to this which would permit that so I think
and correct me if I'm wrong, the commit is incorrect? Even according to nm, the
symbol is local, e.g.:
0000000000000120 t hid_compat_monterey

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Tue, 2 Sep 2008 16:05:43 +0000 (+0200)
Subject: HID: make compat functions static
X-Git-Url:
http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fjikos%2Fhid.git;a=commitdiff_plain;h=f72f87666264c9d4880166bcc69cb5c4cf210449

HID: make compat functions static

Done to avoid sparse warnings about undeclared functions.

Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
Signed-off-by: Jiri Kosina <jkosina@...e.cz>
---

diff --git a/include/linux/hid.h b/include/linux/hid.h
index 15ee33e..164ce7f 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -794,7 +794,7 @@ dbg_hid(const char *fmt, ...)

 #ifdef CONFIG_HID_COMPAT
 #define HID_COMPAT_LOAD_DRIVER(name)	\
-void hid_compat_##name(void) { }	\
+static void hid_compat_##name(void) { }	\
 EXPORT_SYMBOL(hid_compat_##name)
 #else
 #define HID_COMPAT_LOAD_DRIVER(name)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/