linux-kernel - Re: [PATCH] nfsd/nfs4acl: Number of used used array elements needs to be zeroed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080905002035.5c7abde1@psychotron.englab.brq.redhat.com>
Date:	Fri, 5 Sep 2008 00:20:35 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
	neilb@...e.de
Subject: Re: [PATCH] nfsd/nfs4acl: Number of used used array elements needs
 to be zeroed.

On Thu, 4 Sep 2008 11:01:01 -0400
"J. Bruce Fields" <bfields@...ldses.org> wrote:

> On Thu, Sep 04, 2008 at 04:55:18PM +0200, Jiri Pirko wrote:
> > Number of used used array elements needs to be zeroed. It may cause
> > problems otherwise, because it's used uninitialized in find_uid().
> > 
> > Signed-off-by: Jiri Pirko <jpirko@...hat.com>
> > ---
> >  fs/nfsd/nfs4acl.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
> > index 54b8b41..7dcd90f 100644
> > --- a/fs/nfsd/nfs4acl.c
> > +++ b/fs/nfsd/nfs4acl.c
> > @@ -447,11 +447,13 @@ init_state(struct posix_acl_state *state, int cnt)
> >  	state->users = kzalloc(alloc, GFP_KERNEL);
> >  	if (!state->users)
> >  		return -ENOMEM;
> > +	state->users->n = 0;
> >  	state->groups = kzalloc(alloc, GFP_KERNEL);
> >  	if (!state->groups) {
> >  		kfree(state->users);
> >  		return -ENOMEM;
> >  	}
> > +	state->groups->n = 0;
> >  	return 0;
> >  }
> 
> Thanks for the extra eyes on this code, but: surely the kzalloc()'s are
> all that's necessary?  Am I missing something?
Sure you are right. Sorry, my bad...

Jirka
> 
> --b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/