lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Sep 2008 10:04:47 +0200 From: Ingo Molnar <mingo@...e.hu> To: Cyrill Gorcunov <gorcunov@...il.com> Cc: hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de, yhlu.kernel@...il.com, macro@...ux-mips.org Subject: Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs * Cyrill Gorcunov <gorcunov@...il.com> wrote: > Use a nested level for 'for' cycle and break long lines. > For apic_print we should countinue using KERNEL_DEBUG if > we have started to. > @@ -1521,32 +1521,35 @@ static void __init setup_IO_APIC_irqs(vo > apic_printk(APIC_VERBOSE, KERN_DEBUG "init IO_APIC IRQs\n"); > > for (apic = 0; apic < nr_ioapics; apic++) { > - for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) { > + for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) { > > + idx = find_irq_entry(apic, pin, mp_INT); > + if (idx == -1) { hm, i dont really like the super-deep nesting we do here. Could you please split out the iterator into a separate function? That makes the code a lot easier to understand and saves two extra tabs as well for those ugly-looking printk lines. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists