linux-kernel - Re: [E1000-devel] linux-next: Tree for September 4 (PATCH: IXGBE)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080905223634.7a05a2f5.randy.dunlap@oracle.com>
Date:	Fri, 5 Sep 2008 22:36:34 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc:	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	"jgarzik" <jgarzik@...ox.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	<e1000-devel@...ts.sourceforge.net>,
	"Morton" <akpm@...ux-foundation.org>, <linux-next@...r.kernel.org>,
	"LKML" <linux-kernel@...r.kernel.org>,
	<Andrew@...-sf-spam2-b.sourceforge.net>
Subject: Re: [E1000-devel] linux-next: Tree for September 4 (PATCH: IXGBE)

On Fri, 5 Sep 2008 16:47:55 -0700 Brandeburg, Jesse wrote:

> Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > ixgbe needs to be restricted to the same build config (m/y)
> > as DCA since it calls the dca_*() functions.
> > 
> > ixgbe_main.c:(.text+0xd9c09): undefined reference to `dca3_get_tag'
> > ixgbe_main.c:(.text+0xd9cc9): undefined reference to `dca3_get_tag'
> > ixgbe_main.c:(.text+0xda5c1): undefined reference to
> > `dca_add_requester' ixgbe_main.c:(.text+0xda5d6): undefined reference
> > to `dca_remove_requester' text+0xdc162): undefined reference to
> > `dca_add_requester' 
> > text+0xdc1d3): undefined reference to `dca_remove_requester'
> > ixgbe_main.c:(.init.text+0xa74b): undefined reference to
> > `dca_register_notify' ixgbe_main.c:(.devinit.text+0xa4ca): undefined
> > reference to `dca_add_requester' ixgbe_main.c:(.exit.text+0xd21):
> > undefined reference to `dca_unregister_notify'
> > ixgbe_main.c:(.devexit.text+0x72d): undefined reference to
> > `dca_remove_requester' make[1]: *** [.tmp_vmlinux1] Error 1 
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ...
> > +	depends on PCI && INET && DCA
> 
> Looks like you set IXGBE=y and CONFIG_DCA=m.  This depends DCA option is
> not so great because if INTEL_IOATDMA is disabled (and therefore DCA is
> disabled) then ixgbe won't show up as an option.
> 
> How about this instead, use a select INTEL_IOATDMA:
> 
> inline is whitespace busted, sorry. attached is the patch.

OK, that works.  Thanks.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/