linux-kernel - Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080907234418.GB26079@one.firstfloor.org>
Date:	Mon, 8 Sep 2008 01:44:18 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Xen Devel <xen-devel@...ts.xensource.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table

On Sun, Sep 07, 2008 at 03:21:18PM -0700, Jeremy Fitzhardinge wrote:
> __acpi_map_table() effectively reimplements early_ioremap().  Rather
> than have that duplication, just implement it in terms of
> early_ioremap().
> 
> However, unlike early_ioremap(), __acpi_map_table() just maintains a
> single mapping which gets replaced each call, and has no corresponding
> unmap function.  Implement this by just removing the previous mapping
> each time its called.  Unfortunately, this will leave a stray mapping
> at the end.

It would be better to just fix the ACPI code to unmap.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/