linux-kernel - Re: [PATCH 03/18] lirc driver for 1st-gen Media Center Ed. USB IR transceivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809100204.38616.j@jannau.net>
Date:	Wed, 10 Sep 2008 02:04:38 +0200
From:	Janne Grunau <j@...nau.net>
To:	Jonathan Corbet <corbet@....net>
Cc:	Jarod Wilson <jwilson@...hat.com>, linux-kernel@...r.kernel.org,
	Christoph Bartelmus <lirc@...telmus.de>,
	Janne Grunau <j@...nau.net>
Subject: Re: [PATCH 03/18] lirc driver for 1st-gen Media Center Ed. USB IR transceivers

On Tuesday 09 September 2008 21:21:40 Jonathan Corbet wrote:
> > +error:
> > +     mceusb_delete(dev);
> > +     dev = NULL;
> > +     dprintk("%s: retval = %x", __func__, retval);
> > +     up(&minor_table_mutex);
> > +     return retval;
> > +}
>
> This will leak the memory allocated for dev.  It also leaves the
> entry in minor_table pointing to a nonfunctional device.

Argh, I replied too quickly.

kfree(dev) and minor_table cleanup are in mceusb_delete()

Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/