[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200809092139.52369.jwilson@redhat.com>
Date: Tue, 9 Sep 2008 21:39:52 -0400
From: Jarod Wilson <jwilson@...hat.com>
To: Janne Grunau <j@...nau.net>
Cc: Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
Christoph Bartelmus <lirc@...telmus.de>, dconti@....wwu.edu
Subject: Re: [PATCH 03/18] lirc driver for 1st-gen Media Center Ed. USB IR transceivers
On Tuesday 09 September 2008 19:59:32 Janne Grunau wrote:
> > > +static void mceusb_setup(struct usb_device *udev)
> > > +{
> > > + char data[8];
> > > + int res;
> > > +
> > > + memset(data, 0, 8);
> > > +
> > > + /* Get Status */
> > > + res = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
> > > + USB_REQ_GET_STATUS, USB_DIR_IN,
> > > + 0, 0, data, 2, HZ * 3);
> >
> > res is set many times in this function, but it is never checked. It
> > seems to me like the addition of some error handling would be a good
> > idea.
>
> sigh, It would be a good idea, not sure if I'm motivated enough to add
> that to a driver I can't test and I know almost nothing about.
I'll take a look, I've at least got the hardware to test with.
--
Jarod Wilson
jarod@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists