linux-kernel - Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080910131158.GB3468@x200.localdomain>
Date:	Wed, 10 Sep 2008 17:11:58 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	linux-kernel@...r.kernel.org,
	Christine Caulfield <caulfie@...hat.com>,
	David Teigland <teigland@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for
	__u* typedef

On Wed, Sep 10, 2008 at 03:55:04PM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 10, 2008 at 04:14:50PM +0400, Alexey Dobriyan wrote:
> > On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > > --- a/include/linux/dlm_plock.h
> > > +++ b/include/linux/dlm_plock.h
> > 
> > > +#include <linux/types.h>
> > 
> > I'd say that unless you can demonstrate compilation breakage, these will
> > only slow down compilation.
> 
> Do you think that minor slow down is worse than dependence on the order of
> inclusion?

Since it compiles fine there is no such dependency.

Just removing externs from function prototypes makes compiles go faster for
_seconds_.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/