linux-kernel - Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1221056450.4260.17.camel@macbook.infradead.org>
Date:	Wed, 10 Sep 2008 07:20:50 -0700
From:	David Woodhouse <dwmw2@...radead.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	"Kirill A. Shutemov" <kirill@...temov.name>,
	linux-kernel@...r.kernel.org,
	Christine Caulfield <caulfie@...hat.com>,
	David Teigland <teigland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for
	__u* typedef

On Wed, 2008-09-10 at 16:14 +0400, Alexey Dobriyan wrote:
> On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > --- a/include/linux/dlm_plock.h
> > +++ b/include/linux/dlm_plock.h
> 
> > +#include <linux/types.h>
> 
> I'd say that unless you can demonstrate compilation breakage, these will
> only slow down compilation.

Not really. GCC notices the include guard pattern and won't even bother
to open the file the second and subsequent time it's included within a
compilation. I'd be astonished if you can measure any real slowdown at
all.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/