linux-kernel - Re: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48C807A9.60509@intel.com>
Date:	Wed, 10 Sep 2008 10:45:13 -0700
From:	Chris Leech <christopher.leech@...el.com>
To:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
CC:	Christoph Hellwig <hch@...radead.org>,
	jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macros for
 accessing 3-byte arrays as integers

Chris Leech wrote:
> Dave Kleikamp wrote:
>> @@ -62,7 +60,7 @@ struct timestruc_t {
>>   */
>>  typedef struct {
>>  	unsigned len:24;
>> -	unsigned off1:8;
>> +	u8 off1;
>>  	u32 off2;
>>  } lxd_t;
> 
> Shouldn't len here be changed to a __le24?  I think this just changed
> the size of lxd_t by a byte.

Never mind, I see that it's a host order field.  And presently surprised
to see that gcc combines the 24-bit bitfield with the following u8.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/