linux-kernel - [PATCH] ibmasr: remove unnecessary spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080913094717.GA3571@localhost.localdomain>
Date:	Sat, 13 Sep 2008 18:47:19 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Wim Van Sebroeck <wim@...ana.be>, Andrey Panin <pazke@...pac.ru>
Subject: [PATCH] ibmasr: remove unnecessary spin_unlock()

__asr_toggle() is always called with asr_lock held.
But there is unnecessary spin_unlock() call in __asr_toggle().

Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
Cc: Wim Van Sebroeck <wim@...ana.be>
Cc: Andrey Panin <pazke@...pac.ru>
---
 drivers/watchdog/ibmasr.c |    1 -
 1 file changed, 1 deletion(-)

Index: 2.6-git/drivers/watchdog/ibmasr.c
===================================================================
--- 2.6-git.orig/drivers/watchdog/ibmasr.c
+++ 2.6-git/drivers/watchdog/ibmasr.c
@@ -85,7 +85,6 @@ static void __asr_toggle(void)
 
 	outb(reg & ~asr_toggle_mask, asr_write_addr);
 	reg = inb(asr_read_addr);
-	spin_unlock(&asr_lock);
 }
 
 static void asr_toggle(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/