linux-kernel - Re: [PATCH] ibmasr: remove unnecessary spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080915111231.GB28801@pazke.donpac.ru>
Date:	Mon, 15 Sep 2008 15:12:31 +0400
From:	Andrey Panin <pazke@...ke.donpac.ru>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH] ibmasr: remove unnecessary spin_unlock()

On 257, 09 13, 2008 at 06:47:19 +0900, Akinobu Mita wrote:
> __asr_toggle() is always called with asr_lock held.
> But there is unnecessary spin_unlock() call in __asr_toggle().
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: Andrey Panin <pazke@...pac.ru>

Acked-by: Andrey Panin <pazke@...pac.ru>

> ---
>  drivers/watchdog/ibmasr.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: 2.6-git/drivers/watchdog/ibmasr.c
> ===================================================================
> --- 2.6-git.orig/drivers/watchdog/ibmasr.c
> +++ 2.6-git/drivers/watchdog/ibmasr.c
> @@ -85,7 +85,6 @@ static void __asr_toggle(void)
>  
>  	outb(reg & ~asr_toggle_mask, asr_write_addr);
>  	reg = inb(asr_read_addr);
> -	spin_unlock(&asr_lock);
>  }
>  
>  static void asr_toggle(void)
> 

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@...pac.ru		| PGP key: wwwkeys.pgp.net

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)