linux-kernel - Re: [PATCH] Fix declaration of cgroup_mm_owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48CEAEBA.10208@linux.vnet.ibm.com>
Date:	Mon, 15 Sep 2008 11:51:38 -0700
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Paul Menage <menage@...gle.com>
CC:	Pekka Enberg <penberg@...helsinki.fi>,
	Andrew Morton <akpm@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix declaration of cgroup_mm_owner_callbacks()

Paul Menage wrote:
> +static inline void cgroup_mm_owner_callbacks(struct task_struct *old,
> +                         struct task_struct *new) {}

This is confusing coding style, I'd prefer to see the implementation after the
function declaration

Looks good to me otherwise.

-- 
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/