linux-kernel - Re: [PATCH] introduce boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48D000B0.8070108@zytor.com>
Date:	Tue, 16 Sep 2008 11:53:36 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, jbaron <jbaron@...hat.com>
Subject: Re: [PATCH] introduce boot_printk()

Yinghai Lu wrote:
>>
>> Not only do you have duplication, here, but inconsistency...
> 
> how about
> pci_printk(v, KERN_DEBUG "...\n");
> 
> will put
> <pci> <7> ...\n
> in dmesg bug,
> 
> and let vprintk get rid of <pci> like <7>
> 
> is that what you want?
> 

First of all, what is the "v" here, and why not just have
printk(KERN_PCI KERN_DEBUG "...\n");

... and we can do #define PCI_DEBUG KERN_PCI KERN_DEBUG even.

We do have a need for special macros when we're doing device-specific 
prefixes, of course.  If that is what your "v" is meant to be, then 
there was an implicit topic shift in the discussion thread.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/