linux-kernel - Re: [PATCH] introduce boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86802c440809161224s249846a8n15cb1f7eb98d7c05@mail.gmail.com>
Date:	Tue, 16 Sep 2008 12:24:45 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, jbaron <jbaron@...hat.com>
Subject: Re: [PATCH] introduce boot_printk()

On Tue, Sep 16, 2008 at 11:53 AM, H. Peter Anvin <hpa@...or.com> wrote:
> Yinghai Lu wrote:
>>>
>>> Not only do you have duplication, here, but inconsistency...
>>
>> how about
>> pci_printk(v, KERN_DEBUG "...\n");
>>
>> will put
>> <pci> <7> ...\n
>> in dmesg bug,
>>
>> and let vprintk get rid of <pci> like <7>
>>
>> is that what you want?
>>
>
> First of all, what is the "v" here, and why not just have
> printk(KERN_PCI KERN_DEBUG "...\n");
>
> ... and we can do #define PCI_DEBUG KERN_PCI KERN_DEBUG even.
>
> We do have a need for special macros when we're doing device-specific
> prefixes, of course.  If that is what your "v" is meant to be, then there
> was an implicit topic shift in the discussion thread.

will try.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/