linux-kernel - Re: [PATCH 1/5] add DEFINE_LOGLEVEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440809161404v4b59f1c8se1ac61f982a15dd@mail.gmail.com>
Date:	Tue, 16 Sep 2008 14:04:33 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Marcin Slusarz" <marcin.slusarz@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3

On Tue, Sep 16, 2008 at 12:02 PM, Marcin Slusarz
<marcin.slusarz@...il.com> wrote:
> On Tue, Sep 16, 2008 at 11:01:21AM -0700, Yinghai Lu wrote:
>> --- linux-2.6.orig/include/linux/kernel.h
>> +++ linux-2.6/include/linux/kernel.h
>> @@ -104,6 +104,15 @@ extern int console_printk[];
>>  #define minimum_console_loglevel (console_printk[2])
>>  #define default_console_loglevel (console_printk[3])
>>
>> +#define      KERN_LOG_EMERG  0       /* system is unusable                   */
>> +#define      KERN_LOG_ALERT  1       /* action must be taken immediately     */
>> +#define      KERN_LOG_CRIT   2       /* critical conditions                  */
>> +#define      KERN_LOG_ERR    3       /* error conditions                     */
>> +#define      KERN_LOG_WARNING        4       /* warning conditions                   */
>> +#define      KERN_LOG_NOTICE 5       /* normal but significant condition     */
>> +#define      KERN_LOG_INFO   6       /* informational                        */
>> +#define      KERN_LOG_DEBUG  7       /* debug-level messages                 */
>> +
>>  struct completion;
>>  struct pt_regs;
>>  struct user;
>
> maybe
> #define KERN_LOG_EMERG 0,KERN_EMERG
> #define KERN_LOG_ALERT 1,KERN_ALERT
> ...
> ?
>
> or better - create printk2(level, fmt) which prints "<", level, ">", fmt
> and wrap it with pci_printk / acpi_printk?
>

will come out one new version that hpa likes

printk(KERN_PCI KERN_DEBUG "sadfasf\n");

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/