linux-kernel - Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48D01FFB.1010302@lwfinger.net>
Date:	Tue, 16 Sep 2008 16:07:07 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Carlos Corbacho <carlos@...angeworlds.co.uk>
CC:	Matthew Garrett <mjg59@...f.ucam.org>,
	Adel Gadllah <adel.gadllah@...il.com>,
	wireless <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Michael Buesch <mb@...sch.de>, bcm43xx-dev@...ts.berlios.de,
	John Linville <linville@...driver.com>
Subject: Re: Regression in 2.6.27-rcX caused by commit      bc19d6e0b74ef03a3baf035412c95192b54dfc6f

Carlos Corbacho wrote:
>> diff --git a/drivers/net/wireless/b43/rfkill.c
>> b/drivers/net/wireless/b43/rfkill.c
>> index fec5645..e8b2acb 100644
>> --- a/drivers/net/wireless/b43/rfkill.c
>> +++ b/drivers/net/wireless/b43/rfkill.c
>> @@ -49,21 +49,18 @@ static void b43_rfkill_update_state(struct b43_wldev
>> *dev)
>>  	struct b43_rfkill *rfk = &(dev->wl->rfkill);
>>
>>  	if (!dev->radio_hw_enable) {
>> -		rfk->rfkill->state = RFKILL_STATE_HARD_BLOCKED;
>> +		rfkill_force_state(rfk->rfkill, RFKILL_STATE_HARD_BLOCKED);
>>  		return;
>>  	}
>>
>>  	if (!dev->phy.radio_on)
>> -		rfk->rfkill->state = RFKILL_STATE_SOFT_BLOCKED;
>> +		rfkill_force_state(rfk->rfkill, RFKILL_STATE_SOFT_BLOCKED);
>>  	else
>> -		rfk->rfkill->state = RFKILL_STATE_UNBLOCKED;
>> -
>> +		rfkill_force_state(rfk->rfkill, RFKILL_STATE_UNBLOCKED);
>>  }
> 
> Just this should be enough to fix the regression for 2.6.27 (and should be
> trivial to port to b43legacy) in the immediate term (I was planning to
> send something similar).
> 
> The rest of the patch is out-of-scope for 2.6.27, but is definitely along
> he right lines, IMHO (and it would be good if we can get a working version
> of it in to 2.6.28). I may try and look at it later, as I do have my b43
> hardware handy.

This one doesn't crash, but it doesn't turn the light off.

I'm done testing for now!

John,

Revert the patch until the rfkill guys get their house in order.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/